-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #1082] Fix disconnection of HA #1083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanguohuang
changed the title
[ISSUE 1082] Fix the bug of disconnection of HA
[ISSUE 1082] Fix disconnection of HA
Mar 13, 2019
zhanguohuang
changed the title
[ISSUE 1082] Fix disconnection of HA
[ISSUE #1082] Fix disconnection of HA
Mar 22, 2019
LGTM |
supercym
pushed a commit
to supercym/rocketmq
that referenced
this pull request
Aug 22, 2019
duhenglucky
pushed a commit
that referenced
this pull request
Aug 22, 2019
* Remove the useless files * Replace PermSize with MetaspaceSize, details see http://openjdk.java.net/jeps/122 * Update DLedgerCommitLog.java (#1145) Delete useless code * Remove the duplicate content * Polish the comment (#1107) * Minor Typo fix (#860) * [ISSUE #1082] Fix disconnection of HA (#1083) * fixed the text description in chinese doc (#1339) * fix /dev/shm not found on some OSs (#1345) * Refactor the protection logic when pulling * change the MQVersion variable to rocketmq 4.5.2 version; * Minor polish * Fix the wrong package name * [maven-release-plugin] prepare release rocketmq-all-4.5.2 * [maven-release-plugin] prepare for next development iteration * [RIP-15]Add Ipv6 support for RocketMQ
6 tasks
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
* Remove the useless files * Replace PermSize with MetaspaceSize, details see http://openjdk.java.net/jeps/122 * Update DLedgerCommitLog.java (apache#1145) Delete useless code * Remove the duplicate content * Polish the comment (apache#1107) * Minor Typo fix (apache#860) * [ISSUE apache#1082] Fix disconnection of HA (apache#1083) * fixed the text description in chinese doc (apache#1339) * fix /dev/shm not found on some OSs (apache#1345) * Refactor the protection logic when pulling * change the MQVersion variable to rocketmq 4.5.2 version; * Minor polish * Fix the wrong package name * [maven-release-plugin] prepare release rocketmq-all-4.5.2 * [maven-release-plugin] prepare for next development iteration * [RIP-15]Add Ipv6 support for RocketMQ
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this pull request
Oct 19, 2023
* Remove the useless files * Replace PermSize with MetaspaceSize, details see http://openjdk.java.net/jeps/122 * Update DLedgerCommitLog.java (apache#1145) Delete useless code * Remove the duplicate content * Polish the comment (apache#1107) * Minor Typo fix (apache#860) * [ISSUE apache#1082] Fix disconnection of HA (apache#1083) * fixed the text description in chinese doc (apache#1339) * fix /dev/shm not found on some OSs (apache#1345) * Refactor the protection logic when pulling * change the MQVersion variable to rocketmq 4.5.2 version; * Minor polish * Fix the wrong package name * [maven-release-plugin] prepare release rocketmq-all-4.5.2 * [maven-release-plugin] prepare for next development iteration * [RIP-15]Add Ipv6 support for RocketMQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When no message is sent, the master and slave connections are not frequently disconnected.
The logic of reporting heartbeat on slave has been adjusted to make it work better.
Brief changelog
Adjusted lastWriteTimestamp of HAClient.
Verifying this change
Start a master and slave in the default way. Whether or not a message is sent, the master will not disconnect from the slave unless there is an exception.
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.